Skip to content

MNT: ignore PTH linting ruleset by subpackage instead of globally - #16917

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:mnt/ignore_pth_ruleset_by_subpackage
Sep 3, 2024
Merged

MNT: ignore PTH linting ruleset by subpackage instead of globally#16917
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:mnt/ignore_pth_ruleset_by_subpackage

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This is step 0 in my plan to revive #16060: I plan to re-issue this PR in smaller bits targetting specific subpackages to make it easier to cycle.

I intend to keep @MridulS as a commit co-author every step of the way :)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
neutrinoceros force-pushed the mnt/ignore_pth_ruleset_by_subpackage branch 3 times, most recently from 851af64 to d0a22b6 Compare September 2, 2024 14:37
This was referenced Sep 2, 2024
Merged
Merged
@neutrinoceros
neutrinoceros marked this pull request as ready for review September 2, 2024 15:54
nstarman
nstarman reviewed Sep 2, 2024
View reviewed changes
Comment thread astropy/_dev/scm_version.py Outdated
from setuptools_scm import get_version

version = get_version(root=pth.join("..", ".."), relative_to=__file__)
version = get_version(root=Path("../.."), relative_to=__file__)

@nstarman nstarman Sep 2, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OS dependent. .parent or .parents.

@neutrinoceros neutrinoceros Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

mhvk
mhvk approved these changes Sep 2, 2024
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very sensible!

@mhvk mhvk added this to the v7.0.0 milestone Sep 2, 2024
@mhvk

mhvk commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

I think this one doesn't need a changelog entry, but obviously others, where there is an impact in what we accept, might.

@neutrinoceros
neutrinoceros force-pushed the mnt/ignore_pth_ruleset_by_subpackage branch from d0a22b6 to 142822c Compare September 3, 2024 08:10
@neutrinoceros neutrinoceros mentioned this pull request Sep 3, 2024
Closed
pllim
pllim reviewed Sep 3, 2024
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a minor comment. Thanks!

Comment thread .github/workflows/update_astropy_iers_data_pin.py

@pllim pllim Sep 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot really test this until next time it runs and has something to update.

Why call Path(project_file) twice instead of assigning it to variable?

@neutrinoceros neutrinoceros Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I imagine this change was originally obtained directly via ruff. Updated !

nstarman
nstarman approved these changes Sep 3, 2024
View reviewed changes

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@neutrinoceros
neutrinoceros force-pushed the mnt/ignore_pth_ruleset_by_subpackage branch from 142822c to bf903a4 Compare September 3, 2024 15:48
pllim
pllim approved these changes Sep 3, 2024
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
pllim merged commit a77dabc into astropy:main Sep 3, 2024
@neutrinoceros
neutrinoceros deleted the mnt/ignore_pth_ruleset_by_subpackage branch September 3, 2024 16:41
@pllim pllim mentioned this pull request Sep 3, 2024
Closed
This was referenced Sep 4, 2024
Merged
Merged
This was referenced Jun 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes
@mhvk mhvk mhvk approved these changes
@nstarman nstarman nstarman approved these changes
@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson WilliamJamieson is a code owner

Assignees

No one assigned

Labels

dev-automation no-changelog-entry-needed Refactoring testing

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@neutrinoceros @mhvk @pllim @nstarman