Repository navigation
ENH: expose Path-returning API in astropy.config.paths - #17118
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
👋 Thank you for your draft pull request! Do you know that you can use |
4ddc7e9 to
4cd9ede
Compare
4cd9ede to
c7d04e2
Compare
|
Thanks! I will have to test this out with downstream package when I get the chance. |
|
but ... I did everything I could to avoid this being labelled "API change" ? Maybe I am not understanding what this label means exactly ? |
|
Sorry, didn't have time to look in detail. I can remove the label later if it does not apply. Just want to make sure for now. Thanks. |
|
|
||
|
|
||
| def get_cache_dir(rootname: str = "astropy") -> str: | ||
| def get_config_dir(rootname: str = "astropy") -> str: |
There was a problem hiding this comment.
Ah, I see. You added new API instead of changing it. Phew. I might not need downstream testing anymore. Thanks for your thoughtfulness.
There was a problem hiding this comment.
I think we should also make sure the "classic" get_config_dir and get_cache_dir is at least touched once in the tests?
There was a problem hiding this comment.
I haven't (intentionally) removed them from any test that exercises them directly. Instead, I doubled these tests to exercise both APIs instead of just the classic one.
Co-authored-by: P. L. Lim <[email protected]>
Description
Follow up to #16997 as discussed in #16997 (comment), implemented in a purely additive fashion to prevent disruption in downstream users of the historical API (no API change, no deprecation).