Skip to content

Backport PR #17521 on branch v7.0.x (Remove js code bundled with Astropy for DataTables) - #17542

Closed
meeseeksmachine wants to merge 1 commit into
astropy:v7.0.xfrom
meeseeksmachine:auto-backport-of-pr-17521-on-v7.0.x
Closed

meeseeksmachine wants to merge 1 commit into
astropy:v7.0.xfrom
meeseeksmachine:auto-backport-of-pr-17521-on-v7.0.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #17521: Remove js code bundled with Astropy for DataTables

@lumberbot-app lumberbot-app Bot added this to the v7.0.1 milestone Dec 13, 2024
@lumberbot-app lumberbot-app Bot added testing table Docs config external PRs and issues related to external packages vendored with Astropy (astropy.extern) skip-changelog-checks Tells bot to skip changlog checks API change PRs and issues that change an existing API, possibly requiring a deprecation period dev-automation backport-v7.0.x labels Dec 13, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either this or #17480 . Pending CoCo decision. See #17521 (review)

@pllim

pllim commented Dec 16, 2024

Copy link
Copy Markdown
Member

Closing without merge. See #17521 (comment)

@pllim pllim closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period config dev-automation Docs external PRs and issues related to external packages vendored with Astropy (astropy.extern) needs-discussion skip-changelog-checks Tells bot to skip changlog checks table testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants