Skip to content

Add ":valid-package-names:" option to automodsumm/automodapi - #1808

Closed
eteq wants to merge 3 commits into
astropy:masterfrom
eteq:automod-valid-package-names
Closed

eteq wants to merge 3 commits into
astropy:masterfrom
eteq:automod-valid-package-names

Conversation

@eteq

@eteq eteq commented Nov 19, 2013

Copy link
Copy Markdown
Member

See discussion in #1801 for details of why this is actually useful. It should have no effect on the docs right now, but adds an option that may be useful in 0.3.1 and 0.4

@astrofrog

Copy link
Copy Markdown
Member

@eteq - is there any reason to add it to 0.3.0 though? If it'll only be useful for 0.3.1, maybe we can merge after 0.3.0?

@eteq

eteq commented Nov 19, 2013

Copy link
Copy Markdown
Member Author

@astrofrog - technically this is a new feature in automodsumm, so if we strictly adhere to "bugfixes only", it has to wait for 0.4. But given that this is pretty deep in the weeds, I'm filling to consider it a "bugfix" if you are :)

@eteq eteq mentioned this pull request Nov 20, 2013
@astrofrog

Copy link
Copy Markdown
Member

Since minor versions can include documentation fixes, and this code should only affect the docs, as far as I'm concerned this is fine to include in 0.3.1 along with whatever pages use it. I think we should just avoid include any non-critical code in the 0.3.0 release now the RC is out.

@eteq

eteq commented Nov 20, 2013

Copy link
Copy Markdown
Member Author

Alright, good enough for me. I'll close this in favor of #1801, then.

@eteq eteq closed this Nov 20, 2013
@eteq
eteq deleted the automod-valid-package-names branch May 3, 2015 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants