Repository navigation
Conversation
Member
|
@eteq - is there any reason to add it to 0.3.0 though? If it'll only be useful for 0.3.1, maybe we can merge after 0.3.0? |
Member
Author
|
@astrofrog - technically this is a new feature in |
Member
|
Since minor versions can include documentation fixes, and this code should only affect the docs, as far as I'm concerned this is fine to include in 0.3.1 along with whatever pages use it. I think we should just avoid include any non-critical code in the 0.3.0 release now the RC is out. |
Member
Author
|
Alright, good enough for me. I'll close this in favor of #1801, then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in #1801 for details of why this is actually useful. It should have no effect on the docs right now, but adds an option that may be useful in 0.3.1 and 0.4