Repository navigation
Include a limited API build in CI, disabling incompatible extensions - #18236
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
This was referenced Jun 9, 2025
neutrinoceros
requested changes
Jun 9, 2025
neutrinoceros
left a comment
neutrinoceros
left a comment
Contributor
There was a problem hiding this comment.
did you forget to set the env var ?
astrofrog
commented
Jun 9, 2025
Co-authored-by: Clément Robert <[email protected]>
Member
Author
|
@neutrinoceros - thanks for the review! I was setting the env var but globally. It's now done just for the build step as you suggested. This is ready for another review. |
neutrinoceros
approved these changes
Jun 9, 2025
neutrinoceros
left a comment
neutrinoceros
left a comment
Contributor
There was a problem hiding this comment.
Apart from this one last nit, LGTM !
Co-authored-by: Clément Robert <[email protected]>
astrofrog
enabled auto-merge
June 9, 2025 13:38
1 task
pllim
reviewed
Jun 9, 2025
| - cp311-manylinux_x86_64 | ||
|
|
||
|
|
||
| test_limited_api_build: |
Member
There was a problem hiding this comment.
Is this allowed to fail or not? If not, I will have to add it to branch protection. Please advise. Thanks!
Member
Author
There was a problem hiding this comment.
No it is not allowed to fail
This was referenced Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple CI job which checks whether building against the limited API works. This is a very fast job that does not run the tests, so I have included it in the main CI. This is to avoid having to enable all the time consuming CI anytime someone wants to fix something related to the limited API.
Here I make use of the newly released extension-helpers 1.4.0 which includes the ability to opt in to limited API builds via an environment variable.
The idea is that @neutrinoceros could in his PRs remove the removal of the extensions he is fixing.
This PR is a much simple alternative to #18211