Skip to content

Backport PR #18417 on branch v7.1.x (Fixed bugs with WCS slicing, ) - #18430

Merged
pllim merged 1 commit into
astropy:v7.1.xfrom
meeseeksmachine:auto-backport-of-pr-18417-on-v7.1.x
Jul 14, 2025
Merged

pllim merged 1 commit into
astropy:v7.1.xfrom
meeseeksmachine:auto-backport-of-pr-18417-on-v7.1.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #18417: Fixed bugs with WCS slicing,

@meeseeksmachine
meeseeksmachine requested a review from mcara as a code owner July 14, 2025 13:16
@lumberbot-app lumberbot-app Bot added this to the v7.1.1 milestone Jul 14, 2025
@lumberbot-app lumberbot-app Bot added wcs Bug Extra CI Run cron CI as part of PR backport-v7.1.x labels Jul 14, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim previously approved these changes Jul 14, 2025
@pllim
pllim dismissed their stale review July 14, 2025 14:51

CI very red

@pllim

pllim commented Jul 14, 2025

Copy link
Copy Markdown
Member

@astrofrog and @mcara why is the CI failing on backport? Does this patch depends on something else that was not backported?

@pllim
pllim requested a review from astrofrog July 14, 2025 14:52
@pllim

pllim commented Jul 14, 2025

Copy link
Copy Markdown
Member

@pllim
pllim force-pushed the auto-backport-of-pr-18417-on-v7.1.x branch from 1871353 to 8a2964b Compare July 14, 2025 14:57
@pllim
pllim merged commit 6f46b9b into astropy:v7.1.x Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Extra CI Run cron CI as part of PR wcs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants