Repository navigation
Find metadata in CDS readme even for gzipped files - #18506
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
pre-commit.ci autofix |
| for pattern in names: | ||
| if fnmatch.fnmatch(self.data.table_name, pattern): | ||
| if fnmatch.fnmatch( | ||
| self.data.table_name.rstrip(".gz"), pattern |
There was a problem hiding this comment.
Assuming people don't get naughty and use suffix variations like .tgz, .gzip, .GZ, and so on? 😬
There was a problem hiding this comment.
CDS itself only uses ".gz". This is intentionally narrow to avoid casting too wide a net of catching random stuff, to goal is to make it work with what CDS gives you (in particular, if you get it directly fro the URL as in #6549, which I tested manually with this branch, but I didn't think it was necessary to add another remote-data test for that. Those are more flaky then tests with included files).
There was a problem hiding this comment.
Very reasonable as long as CDS sticks to gzip. For really large files a format with better and faster decompression could actually make sense, but if you do that on your locally downloaded file, you can also think of xz'ing the readme as well.
There was a problem hiding this comment.
.rstrip is incorrect -- it removes all occurrences of ., g, and z from the filename; you need .removesuffix (python >= 3.9, so OK):
"yaygggzzz.gz".rstrip(".gz")
# 'yay'
"yaygggzzz.gz".removesuffix(".gz")
# 'yaygggzzz'
|
The coverage failure makes no sense. All the allegedly untested lines are in files that have nothing to do with this PR. |
|
Patch coverage is 100% so I won't worry too much about it. |
CDS/Vizier serves large datafiles in gzipped for by default, but the ".gz" ending is not included in the filename in the ReadMe file and thus the reader will not find the metadata and fail. This PR simply strips off any ".gz" ending before searching the ReadMe. closes astropy#6549
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
5 participants
Description
CDS/Vizier serves large datafiles in gzipped for by default, but the ".gz" ending is not included in the filename in the ReadMe file and thus the reader will not find the metadata and fail.
This PR simply strips off any ".gz" ending before searching the ReadMe.
fixes #6549