Repository navigation
Update constant.py to match repr to attributes. - #4146
Closed
DanielLenz wants to merge 1 commit into
Closed
DanielLenz wants to merge 1 commit into
DanielLenz wants to merge 1 commit into
Conversation
Rename Error -> Uncertainty and Units -> Unit to match the attributes.
DanielLenz
changed the title
Contributor
|
+1. Note the build failures due to omitting to update the documentation |
Member
|
It looks like the branch was deleted without merging? |
Author
|
I messed up the branches, so I created a new pull request, including the changes in the docs. First contribution, please bear with me. |
Member
|
@dlenz-bonn , no problem. Can you please link to your new PR as a comment in #4145, so there is a clear cross-reference for reviewers? Thank you for contributing! |
Member
|
Ah, never mind. I see the new PR now. |
Member
|
Next time just let me know--in the vast majority of cases the git issues can be sorted out without creating a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Error -> Uncertainty and Units -> Unit in the
reprto match the attributes.Requested in #4145