Repository navigation
fixed wrong rendered changelog entry and contributor name [skip ci] - #4683
Conversation
Also added myself as contributor [skip ci]
|
Should I remove the change regarding |
|
IMHO, if there is no way to verify for sure that J stands for Jason, it is best to keep it as-is. |
|
@pllim Ok I've reverted that change. Should I add an issue about it or is there another way to keep sphinx from rendering his initial |
|
Ah, I see the problem now. I fixed it in #4777. |
|
Thanks, @MSeifert04 . I think this is okay to merge, but I am not sure how to milestone it (1.0.10 or 1.1.3), so I am leaving this open until someone can comment on the correct milestone to use. |
|
@pllim You could have just told me how to fix it. 😄 This won't cause merge conflicts? |
|
@MSeifert04 - You can see if it conflicts here: the green check above the comment box changes to a grey one. (But it didn't, so there isn't any conflict.) |
|
@bsipocz Thank you. I always had the impression this just determines if there are conflicts with the current master not with other (unmerged) PRs. Thank you for the clarification. |
|
Ohh, sorry you're right. I somehow assumed that the other PR is already merged... |
|
We can always merge this one first and I'll resolve any conflict on the other one. ;) |
|
That PR was just me being lazy. I was experimenting with a fix, found it, and just pushed it out as PR. If you use that fix here, I'll just close mine. I apologize for any inconvenience caused. |
|
@pllim No problem. I was just surprised. |
|
This looks uncontroversial enough, especially given that you're listed as contributor No. 24 in ranking as of this morning. I'm just going to merge this. If someone thinks I tagged the wrong milestone, feel free to change it. |
And I also added myself as contributor. I hope that's okay.
And I really hope
J. Xavier Prochaskais reallyJason Xavier Prochaska. Is there any way to find out for sure? I googled for a while and found no GitHub name but some homepages (probably) about him calling him "Jason"