Repository navigation
Update example code for brightness_temperature in equivalencies.py - #4762
Closed
adeleplunkett wants to merge 1 commit into
Closed
adeleplunkett wants to merge 1 commit into
adeleplunkett wants to merge 1 commit into
Conversation
Multiply instead of divide in the equation for beam area (beam_area = 2.*np.pi*(bmaj*bmin*fwhm_to_sigma**2)), because of the way fwhm_to_sigma is defined with (8*np.log(2))**0.5 already in the denominator. I think this is consistent with the equations shown on this page: https://www.cv.nrao.edu/course/astr534/Interferometers2.html But, you can ignore this if I have made a mistake or wrong assumption.
Member
|
This needs to be rebased to |
Member
|
I'm not 100% sure, but I think this requires actually closing this and creating a new PR, @adeleplunkett (the thing @pllim said about it being supposed to be against |
Author
|
Ok I will close this, and make a comment in master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiply instead of divide in the equation for beam area (beam_area = 2.np.pi(bmaj_bmin_fwhm_to_sigma**2)), because of the way fwhm_to_sigma is defined with (8*np.log(2))**0.5 already in the denominator.
I think this is consistent with the equations shown on this page: https://www.cv.nrao.edu/course/astr534/Interferometers2.html But, you can ignore this if I have made a mistake or wrong assumption.