Repository navigation
Remove unnecessary sort when defining __all__ - #4785
Merged
Merged
Conversation
Member
|
👍 |
1 similar comment
Member
|
👍 |
Contributor
|
Parenthesis can be removed as well ;-) |
larrybradley
force-pushed
the
all_sorted
branch
from
April 18, 2016 19:22
c3e86d1 to
dfc90e0
Compare
Member
Author
|
Yes, of course. Thanks for catching that, @saimn. Done! |
Member
|
Thanks @larrybradley! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is unnecessary to sort the entries in
__all__. I think this is a holdover from when the entries were not automatically sorted in the docs.