Skip to content

Changing pep8 tool to pycodestyle - #5107

Merged
astrofrog merged 2 commits into
astropy:masterfrom
bsipocz:travis_change_pep8_pycodestyle
Jul 30, 2016
Merged

Changing pep8 tool to pycodestyle#5107
astrofrog merged 2 commits into
astropy:masterfrom
bsipocz:travis_change_pep8_pycodestyle

Conversation

@bsipocz

@bsipocz bsipocz commented Jun 15, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

They had recently changed the name, and however there is a cooling down deprecation period, it's worth changing this now (rather than getting the warnings).

We also use pytest-pep8, but it's not yet updated.

@bsipocz

bsipocz commented Jun 21, 2016

Copy link
Copy Markdown
Member Author

Could someone restart this travis?

@mwcraig

mwcraig commented Jun 21, 2016

Copy link
Copy Markdown
Member

The failing builds have been restarted.

@bsipocz

bsipocz commented Jun 21, 2016

Copy link
Copy Markdown
Member Author

OK, this was failing due to PyCQA/pycodestyle#550, but now should pass.

@bsipocz

bsipocz commented Jun 22, 2016

Copy link
Copy Markdown
Member Author

Could someone please restart the failing build once again? Now it should really pass.

@mwcraig

mwcraig commented Jun 22, 2016

Copy link
Copy Markdown
Member

Done

Thanks,
Matt Craig

On Jun 22, 2016, 6:08 PM -0500, Brigitta [email protected], wrote:

Could someone please restart the failing build once again? Now it should really pass.

—
You are receiving this because you commented.
Reply to this email directly,view it on GitHub(#5107 (comment)), ormute the thread(https://github.com/notifications/unsubscribe/ABGBH5DR2INZrcaDy9GWTOkeEgR5nXW7ks5qOcBTgaJpZM4I24cF).

@mhvk

mhvk commented Jun 23, 2016

Copy link
Copy Markdown
Contributor

@bsipocz - this looks good to me!

For travis, I thought runs can be restarted both by the committer and by someone with push privilege. Is this not true? (You may need to register with travis; I don't recall any more what the process was... cc @astrofrog).

@bsipocz

bsipocz commented Jun 23, 2016

Copy link
Copy Markdown
Member Author

@mhvk - Yes, that would be logical workflow, but it doesn't work for me like that. I can cancel builds, not only mine, but cannot restart the builds.

@pllim pllim mentioned this pull request Jul 7, 2016
Merged
@astrofrog

astrofrog commented Jul 30, 2016

Copy link
Copy Markdown
Member

@bsipocz - sorry for not merging that sooner, can you rebase?

@bsipocz
bsipocz force-pushed the travis_change_pep8_pycodestyle branch from c4efd55 to 5340cf4 Compare July 30, 2016 20:48
@bsipocz

bsipocz commented Jul 30, 2016

Copy link
Copy Markdown
Member Author

Np, rebased now.

@astrofrog

astrofrog commented Jul 30, 2016

Copy link
Copy Markdown
Member

@bsipocz - thanks!

@astrofrog astrofrog added this to the v1.3.0 milestone Jul 30, 2016
@astrofrog
astrofrog merged commit 328e038 into astropy:master Jul 30, 2016
@astrofrog

astrofrog commented Jul 30, 2016

Copy link
Copy Markdown
Member

(Travis failure unrelated, due to sesame being down)

@astrofrog

astrofrog commented Jul 30, 2016

Copy link
Copy Markdown
Member

Haha @astrobot, I win 👻

@pllim pllim mentioned this pull request Aug 1, 2016
Merged
@bsipocz bsipocz mentioned this pull request Jan 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog-entry-needed testing

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@bsipocz @mwcraig @mhvk @astrofrog @pllim