Repository navigation
Conversation
|
(I milestoned it 1.3 because of the #5104 stuff, but the line style change we might just backport to 1.2.x as a single commit, as the example right now doesn't really make sense) |
|
Ah, yes, I meant to do
(I hate that default blue) |
|
Ah, now I get the intent @adrn - thanks for clearing that up. Last push updated back to plot with |
|
Note that the travis failure seems to be due to sesame being down |
|
Huh, sounds like there's a |
|
@astrofrog - it's from the example gallery, which doesn't obey It does raise a question about that particular example though (the coordinates one) - that example doesn't work without remote data but we still want it to be generated in sphinx |
|
@eteq @astrofrog - With a quick look it seems that there are two urls given for sesame, and the first one (cds) is indeed not responding, however the second one (cfa) seems to be working, which means there is a bug somewhere. I think it may worth an issue. |
|
I think it's a separate issue to deal with the question of @mhvk - did you want to take a look at this or should I just go ahead and merge this? |
| zs = -zs | ||
|
|
||
| X, Y, Z = SGR_MATRIX.T.dot(np.array([Xs, Ys, Zs])) | ||
| x, y, z = matrix_product(SGR_MATRIX.T, np.array([xs, ys, zs])) |
|
@eteq - I now had a quick look, and am slightly wondering if we're being helpful here by writing it in such a way that it would still fail for multi-dimensional vectors or matrices.... Would it be possible to follow the built-in transformations more closely? In particular, use |
|
Closed by #5541 |

This updates the Sgr coordinates example both for changes in #5104 and to actually show the plot that I think is intended. To see the key difference, the current doc example looks like this:

vs after this PR it looks like:

I'm pretty sure the first one is just an oversight, but perhaps @adrn can clarify what was meant by that (the problem was a
linestyle='none'inplt.plot)?Also, @mhvk, does this look right re: use of #5104 new features?