Skip to content

Deprecate VO Simple Cone Search - #5904

Merged
pllim merged 1 commit into
astropy:masterfrom
pllim:deprecate-conesearch
Mar 31, 2017
Merged

Deprecate VO Simple Cone Search#5904
pllim merged 1 commit into
astropy:masterfrom
pllim:deprecate-conesearch

Conversation

@pllim

@pllim pllim commented Mar 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Astroquery 0.3.5 must be released before this is merged.

Follow-up of astropy/astroquery#859, next step towards #5558. Local test results with remote data:

===== test session starts =====
platform linux -- Python 3.5.2, pytest-3.0.4, py-1.4.31, pluggy-0.4.0

Running tests with Astropy version 2.0.dev18040.
Running tests in lib.linux-x86_64-3.5/astropy/vo docs/vo.

Date: 2017-03-23T13:04:20

Platform: Linux-2.6.32-642.15.1.el6.x86_64-x86_64-with-redhat-6.8-Santiago

Executable: .../bin/python

Full Python Version: 
3.5.2 |Continuum Analytics, Inc.| (default, Jul  2 2016, 17:53:06) 
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]

encodings: sys: utf-8, locale: UTF-8, filesystem: utf-8
byteorder: little
float info: dig: 15, mant_dig: 15

Numpy: 1.12.0
Scipy: 0.18.1
Matplotlib: 2.0.0
h5py: 2.6.0
Pandas: 0.19.2
Cython: 0.24
Using Astropy options: remote_data: any.

rootdir: /tmp/astropy-test-q5z_veyw, inifile: setup.cfg
collected 72 items 

astropy/vo/client/tests/test_conesearch.py ......x..........x.
astropy/vo/client/tests/test_vos_catalog.py ...............
astropy/vo/samp/tests/test_client.py ....
astropy/vo/samp/tests/test_errors.py ...
astropy/vo/samp/tests/test_hub.py ...
astropy/vo/samp/tests/test_hub_proxy.py .....
astropy/vo/samp/tests/test_hub_script.py .
astropy/vo/samp/tests/test_standard_profile.py ...
astropy/vo/samp/tests/test_web_profile.py ..
astropy/vo/validator/tests/test_inpect.py ....
astropy/vo/validator/tests/test_validate.py ....
../docs/vo/index.rst .
../docs/vo/conesearch/client.rst .
../docs/vo/conesearch/index.rst .
../docs/vo/conesearch/validator.rst .
../docs/vo/samp/advanced_embed_samp_hub.rst .
../docs/vo/samp/example_clients.rst .
../docs/vo/samp/example_hub.rst .
../docs/vo/samp/example_table_image.rst .
../docs/vo/samp/index.rst .

===== pytest-warning summary =====
WC1 None [pytest] section in setup.cfg files is deprecated, use [tool:pytest] instead.
===== 70 passed, 2 xfailed, 1 pytest-warnings in 59.22 seconds =====

With this change, most user-facing API in astropy.vo.client and astropy.vo.validator will emit AstropyDeprecationWarning, except for their related config and exceptions (IMHO that would be overkill). Example:

>>> from astropy.coordinates import SkyCoord
>>> from astropy.vo.client import conesearch
>>> c = SkyCoord.from_name("M31")
>>> result = conesearch.conesearch(c, 0.1)
WARNING: AstropyDeprecationWarning: The conesearch function is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.conesearch.conesearch instead. [astropy.utils.decorators]
WARNING: AstropyDeprecationWarning: The call_vo_service function is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.vos_catalog.call_vo_service instead. [astropy.vo.client.conesearch]
WARNING: AstropyDeprecationWarning: The get_remote_catalog_db function is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.vos_catalog.get_remote_catalog_db instead. [astropy.vo.client.vos_catalog]
Downloading ...
WARNING: AstropyDeprecationWarning: The VOSDatabase class is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.vos_catalog.VOSDatabase instead. [astropy.vo.client.vos_catalog]
WARNING: AstropyDeprecationWarning: The VOSBase class is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.vos_catalog.VOSBase instead. [astropy.vo.client.vos_catalog]
WARNING: AstropyDeprecationWarning: The VOSCatalog class is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.vos_catalog.VOSCatalog instead. [astropy.vo.client.vos_catalog]
WARNING: AstropyDeprecationWarning: The VOSBase class is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.vos_catalog.VOSBase instead. [astropy.vo.client.vos_catalog]
Trying http://...
...
WARNING: AstropyDeprecationWarning: The vo_tab_parse function is deprecated and may be removed in a future version.
        Use astroquery.vo_conesearch.vos_catalog.vo_tab_parse instead. [astropy.vo.client.vos_catalog]

@pllim pllim added this to the v2.0.0 milestone Mar 23, 2017
pllim
pllim commented Mar 23, 2017
View reviewed changes
Comment thread CHANGES.rst Outdated
- ``astropy.vo``
- Cone Search now issues deprecation warning because it is moved to
Astroquery 0.3.5 and will be removed from Astropy in a future version.
[#5558, #5901]

@pllim pllim Mar 23, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess was off by 3. Will fix!

@pllim
pllim force-pushed the deprecate-conesearch branch from 65675a0 to 861e323 Compare March 23, 2017 20:15
@pllim
pllim force-pushed the deprecate-conesearch branch from 861e323 to f3f2dfd Compare March 24, 2017 17:03
@bsipocz

bsipocz commented Mar 31, 2017

Copy link
Copy Markdown
Member

@pllim - astroquery 0.3.5 is released, so probably we can go ahead with this.

@bsipocz

bsipocz commented Mar 31, 2017

Copy link
Copy Markdown
Member

(Also, it seems that ginga is the only affiliate that uses conesearch, but it doesn't run tests against LTS. So merging it now should be OK, the deprecation shouldn't cause troubles as the overwrite/clobber did.)

@MSeifert04

MSeifert04 commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

Well, the overwrite/clobber thing should be "reverted" by now, right? 😄

@bsipocz

bsipocz commented Mar 31, 2017

Copy link
Copy Markdown
Member

Sure, it is reverted, it's just an excellent example to the deprecation problem, that shouldn't be a problem here, at least not for any of the packages we care the most about.

@pllim

pllim commented Mar 31, 2017

Copy link
Copy Markdown
Member Author

I am a bit nervous to hit the merge button but here it goes...

@pllim
pllim merged commit 1eb1916 into astropy:master Mar 31, 2017
@pllim
pllim deleted the deprecate-conesearch branch March 31, 2017 16:58
@pllim pllim mentioned this pull request Apr 3, 2017
Closed
@pllim pllim mentioned this pull request Jun 28, 2017
Closed
@pllim pllim mentioned this pull request Mar 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Last-before-release vo.conesearch vo

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pllim @bsipocz @MSeifert04