Skip to content

WIP Quantity masked array - #6005

Closed
mhvk wants to merge 6 commits into
astropy:masterfrom
mhvk:quantity-masked-array
Closed

mhvk wants to merge 6 commits into
astropy:masterfrom
mhvk:quantity-masked-array

Conversation

@mhvk

@mhvk mhvk commented May 4, 2017

Copy link
Copy Markdown
Contributor

DO NOT MERGE -- Not remotely complete, just here so people can have a look (mostly @taldcroft). I'm not sure at all this is even the way to go.

@taldcroft

Copy link
Copy Markdown
Member

@mhvk - I had a quick look. Do you think the problem with MaskedArray * unit is solvable?

@mhvk
mhvk force-pushed the quantity-masked-array branch from f68fe06 to 269e915 Compare May 23, 2017 02:07
@mhvk

mhvk commented May 24, 2017

Copy link
Copy Markdown
Contributor Author

@taldcroft - it turns out in numpy >=1.10, the MaskedArray * unit problem is solved; presumably, some work-around would be possible for 1.9. But really I should look at your PRs, and think more about the implication of possibly having NaN in the arrays.

@mhvk mhvk mentioned this pull request Jun 27, 2017
@astropy-bot

astropy-bot Bot commented Oct 26, 2017

Copy link
Copy Markdown

Hi humans 👋 - this pull request hasn't had any new commits forapproximately 5 months. I plan to close this in a month if the pullrequest doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open anissue instead if a reminder is needed to revisit in the future. Maintainersmay also choose to add keep-open label to keep this PR open but it isdiscouraged unless absolutely necessary.

If this PR is still needed to be reviewed, as an author, you can rebase itto reset the clock. You may also consider to send a reminder e-mail about itto the astropy-dev mailing list.

If you believe I commented on this pull request incorrectly, please report this here.

@astropy-bot

astropy-bot Bot commented Nov 30, 2017

Copy link
Copy Markdown

⏰ Time's up! ⏰

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

@astropy-bot astropy-bot Bot closed this Nov 30, 2017
@pllim pllim added the closed-by-bot Closed by stale bot label May 25, 2018
@mhvk mhvk added closed-by-bot Closed by stale bot and removed closed-by-bot Closed by stale bot labels Nov 15, 2018
@mhvk mhvk mentioned this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants