Repository navigation
Disable vo.samp tests that fail with openssl >1.1. - #6091
Merged
bsipocz merged 1 commit intoMay 18, 2017
Merged
Conversation
Member
|
@mhvk - Milestoned as 2.0, but please feel free to change that if you think think needs to be backported. I still plan to do one last 1.3.x and 1.0.x, unless the coordinators says it's not necessary. |
Contributor
Author
|
Probably fine to leave it for 2.0. |
Contributor
Author
|
OK, it seems I didn't break anything, and locally this helps ensure all tests pass... |
Member
|
This seems trivial, so I'm merging now. Thanks @mhvk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like tests to just work on my workstation, and
vo.samphas now been broken for recent openssl for 6 months (#5460), so I think it is time to just disable the tests (for recent openssl only) until this is fixed.