Repository navigation
Ignore generated examples for pytest - #6228
Conversation
When the doc examples have been generated, pytest imports (and run) these files, included `skip_create-large-fits.py` which creates a 12Gb array in memory ! Also remove the `astropy/sphinx` setting as this directory was removed from Astropy a long time ago.
|
I canceled the Travis build as I think it's not needed to run everything if it pass in CircleCI/AppVeyor. |
|
Looks good to me. Merging as we've already tested this when tried to figure out the timeout issues in #5782 |
|
I don't disagree but I thought that solution didn't work for #5782 and then we ended up removing some Python file and embedded the code in RST? |
|
I didn't follow the comments from #5782 , but this should not have an influence on Travis, which always starts with a clean environment. |
Yes, I remember now. I was testing locally but the error went away after I did a |
|
To clarify: the problem here occurs only once you have run |
|
Maybe something funky happens where pytest awaits some signal from the script that never arrives... ¯\(ツ)/¯ |
|
And there are other examples that are executed during pytest's collect phase: https://github.com/astropy/astropy/tree/master/docs/wcs/examples |
|
Anyway, I think it's good to have this in. It won't affect our CI as they start from scratch, but will be better for people running the tests after they've built the docs. |
|
@saimn , it's funnier on a Windows laptop. 😛 |
|
@pllim - Out of curiosity, what's the behavior on Windows for this case ? |
|
Of course the laptop was not usable for a few minutes ! 😁 |
|
I am just imagining a blue screen. But for academic purpose, I can test this next week... |
|
Turns out I can't even get the doc to build on Windows (astropy/sphinx-automodapi#28). "What a twist!" |
|
So... after I hacked around the Update: And just for completeness, with your fix on my Windows laptop, all the tests passed except for 6 remote data ones, that are probably due to connection issues. |
When the doc examples have been generated, pytest imports (and run) these files, included
skip_create-large-fits.pywhich creates a 12Gb array in memory !Also remove the
astropy/sphinxsetting as this directory was removed from Astropy a long time ago.