Repository navigation
Rearrange import order in io.misc.connect - #6607
Conversation
|
Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 |
|
Okay, I wouldn't mind just including it on a "it can't harm and possibly fixes it" basis. But I wonder ... how can the current state lead to transient (and they are) failures while it would work with the fix. Is there some randomness (threads/race-conditions) to the sphinx module discovery? |
Not sure. But the fact that it does not fail every time on Travis CI suggests transient nature. |
MSeifert04
left a comment
MSeifert04
left a comment
There was a problem hiding this comment.
These connect modules really mess with the separation or at least loose-coupling between subpackages.
As said before it probably won't hurt and it may fix the error so 👍
|
OK merging this then. If you see this error again, the fool-proof way (but also ugly) is to actually move those functions from |
2 participants
Fix #6604 (doc build failure in Python 3.6)
Note: Even if this doesn't fix the problem (although now I can build doc successfully in my local Python 3.6 but I worry that the failure is transient and just happen not to appear when I ran it) at least import order is "cleaner"; i.e., import upper-level sub-package before local modules within the same sub-package.
c/c @MSeifert04 @saimn @drdavella