Repository navigation
Fixing version dependent CI failures - #6943
Conversation
bsipocz
added
zzz 💤 merge-when-ci-passes
|
Hi there @bsipocz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
a84511c to
a01f63f
Compare
| obj1 = class1([b'a', b'c']) | ||
| if class2 is str: | ||
| obj2 = 'a' | ||
| obj2 = str('a') |
There was a problem hiding this comment.
@mhvk - This is an ugly workaround for the unicode literal testing. Frankly, I don't fully understand why a string caused an issue here, but not when it was in a list below.
I'm going ahead with this hack for now to get the rest of the release tested.
The code itself seemed OK, but please let me know if I oversee something critical, and thus it's better not to backport #6899
2 participants
These commits are cherry-picked out of the unrelated #6918 PR. I'm opening this PR as a new failure is showed up there, but in the meantime the rest of the bugfix branch can be sorted with these.