Skip to content

Use broadcast_to from compat for Numpy 1.9 - #6953

Merged
bsipocz merged 1 commit into
astropy:v2.0.xfrom
pllim:fix-broadcast-to
Dec 9, 2017
Merged

bsipocz merged 1 commit into
astropy:v2.0.xfrom
pllim:fix-broadcast-to

Conversation

@pllim

@pllim pllim commented Dec 8, 2017 •

Copy link
Copy Markdown
Member

np.broadcast_to is new in Numpy 1.10.

xref #6918

@astropy-bot

astropy-bot Bot commented Dec 8, 2017 •

Copy link
Copy Markdown

Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@mhvk

mhvk commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

The lesser joys of backporting...

@pllim

pllim commented Dec 8, 2017

Copy link
Copy Markdown
Member Author

Failures are unrelated to the particular bug that I am trying to fix here.

@bsipocz

bsipocz commented Dec 9, 2017

Copy link
Copy Markdown
Member

Thanks @pllim. Apparently I have to be more careful with backports.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bsipocz
bsipocz merged commit 1f4722a into astropy:v2.0.x Dec 9, 2017
@pllim
pllim deleted the fix-broadcast-to branch December 11, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants