Repository navigation
TST: Fix parallel data download test for v2.x - #7586
Conversation
|
Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
|
p.s. Ignore |
|
@bsipocz , is this ok to merge? |
|
@pllim - If it passes the tests then good to go. I need to restart the failing circleCI one though, as that's the only one that actually does parallel testing on python2... |
|
@pllim - I'm afraid the failure is related: |
|
😱 OK thx for alerting me to the failure. I'll have a look soon. Update: I can't reproduce this error in a local PY2 env. I'll just have to guess at the fix and push it here and see... 🤞 |
cff74b6 to
fd6b2a9
Compare
fd6b2a9 to
44b0765
Compare
|
All tests pass now, so merging. Thanks for the review! |
Backport straight to v2.x for #7575