Repository navigation
remove deprecated _naxis - #9465
Merged
Merged
Conversation
bsipocz
approved these changes
Oct 25, 2019
bsipocz
added
the
zzz 💤 merge-when-ci-passes
Member
|
Thank you @nden! |
16 tasks done
pllim
approved these changes
Oct 25, 2019
pllim
added
skip-changelog-checks
Member
|
@pllim - I need the label for the release script (note, while there are changelog changes in this PR, they are not related to this one, so the scripts would complain). |
Member
|
Oh, ops, sorry! I was under the impression that we made "skip-changelog-checks" just for such situation but I must have misremembered. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes part of #8888 - removes the deprecated
_naxis1and_naxis2from astropy.wcs.I didn't add a change log entry as these were private, though I can add one if necessary.
The deprecated
rotations.rotation_matrix_from_anglewas removed in #9369, I added a log message about this here. Also noticed that some of the new additions to modeling were underAPI Changesinstead ofNew Featuresand moved them.