Repository navigation
TST: Ignore test warnings in modeling - #9538
Conversation
pllim
changed the title
744ddd7 to
b35a2ec
Compare
|
Ready for review! |
nden
left a comment
nden
left a comment
There was a problem hiding this comment.
Thanks for all this work! I feel like some of the warnings should be caught in the code and never reach the user but it's a task for a different PR.
|
|
||
| @pytest.mark.filterwarnings("ignore:BlackBody provides the same capabilities") | ||
| @pytest.mark.filterwarnings( | ||
| r"ignore:Input contains invalid wavelength/frequency value\(s\)") |
There was a problem hiding this comment.
I'm not sure if this warning should be ignored or caught. Although only one of the values is raising it so may be it should have been a separate test.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| self.y1 = np.arange(1, 10, .1) | ||
| self.y2, self.x2 = np.mgrid[:10, :8] | ||
|
|
||
| @pytest.mark.filterwarnings(r'ignore:.*:RuntimeWarning') |
There was a problem hiding this comment.
For some reason I can't find a test log that shows the warnings. Can you point me to one. I'm curious what raises this RuntimeWarning.
There was a problem hiding this comment.
You can see it in the log of #7928. For example, starting at https://travis-ci.org/astropy/astropy/jobs/608405975#L2929
|
Looks like the failures are not related. Feel free to merge if you agree. |
b35a2ec to
246d32c
Compare
pllim
added
the
zzz 💤 merge-when-ci-passes
|
p.s. @bsipocz , if you think this can be in 4.0, feel free to re-milestone. I have no strong opinion either way. |
|
Looks good. Please squash all commits. |
|
Thanks @pllim! |
|
Re: squashing -- ops, saw the comment too late. Thanks for the review, @nden! |
|
5 commits for ~200 lines of change is super reasonable, so I didn't feel like enforcing the squash but rather get on with the merge. |
3 participants
Description
This pull request is to address
modelingtests emittingAstropyDeprecationWarningwhen testing deprecatedBlackBody1Dand theMexicanHat*models, and other warnings.Part of #7928