Skip to content
This repository was archived by the owner on Nov 11, 2024. It is now read-only.
This repository was archived by the owner on Nov 11, 2024. It is now read-only.

Appveyor picks up ci-helpers test #265

Description

@bsipocz

As @saimn points out in #261, appveyor tries to run the ci-helpers test, too rather than staying within the astropy-helpers subdir. This behaviour is new and started about a month ago. While the workaround in 909b75b works, it would be great to see what caused the changes.

Here are two runs of the same commit:

Activity

  1. bsipocz commented on Nov 23, 2016

    @bsipocz
    MemberAuthor

    OK, the difference is that the old build used pytest v2.9.2 while the new failing is running v3.x

  2. bsipocz commented on Nov 23, 2016

    @bsipocz
    MemberAuthor

    OK, sorry for the noise, this was actually a ci-helpers issue with pytest 3.x, that @astrofrog fixed today. However I still think that the ci-helpers test file shouldn't be picked up here.

  3. saimn commented on Nov 24, 2016

    @saimn
    Contributor

    @bsipocz - Note that for Travis the test command was already running tests only for the astropy_helpers directory: https://github.com/astropy/astropy-helpers/blob/master/.travis.yml#L66

  4. astrofrog commented on Nov 24, 2016

    @astrofrog
    Member

    Fundamentally, this is just because the test command is py.test rather than py.test astropy_helpers. We should probably change it to the latter. The issue I fixed with ci-helpers was actually useful to identify packages that are running the ci-helpers tests by mistake ;)

  5. bsipocz commented on Nov 24, 2016

    @bsipocz
    MemberAuthor

    @saimn - Fair enough. That case it was probably only a bug in pytest 2.9.2 to not pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions