Skip to content

Changing parametrized tests to be pytest 3.2.0 compatible - #578

Merged
larrybradley merged 2 commits into
astropy:masterfrom
bsipocz:pytest_3.2.0_compatibility
Sep 27, 2017
Merged

larrybradley merged 2 commits into
astropy:masterfrom
bsipocz:pytest_3.2.0_compatibility

Conversation

@bsipocz

@bsipocz bsipocz commented Aug 2, 2017

Copy link
Copy Markdown
Member

No description provided.

@larrybradley

Copy link
Copy Markdown
Member

The python 3.4 test fails because it's using pytest 3.0.5, which apparently does not have the pytest.param fixture.

I think the best workaround for now is simply to limit the pytest version to < 3.2.

@bsipocz

bsipocz commented Aug 2, 2017

Copy link
Copy Markdown
Member Author

I can build a pytest 3.1 version for py3.4 in the astropy-ci-extras channel.

@eteq eteq mentioned this pull request Aug 3, 2017
@larrybradley

Copy link
Copy Markdown
Member

@bsipocz I just reran the failing py3.4 test and it it still using pytest 3.0.5 (and thus still failing). Ping!

@bsipocz

bsipocz commented Sep 25, 2017

Copy link
Copy Markdown
Member Author

@larrybradley - Yes, we run into troubles there with the machinery, I can only forward the ping to @mwcraig as he's the only one with a full understanding of our conda infrastructure.
astropy/conda-channel-ci-extras#22

@larrybradley

Copy link
Copy Markdown
Member

As a temporary workaround could I install an updated pytest via pip? Or perhaps we should drop the py3.4 test?

@mwcraig

mwcraig commented Sep 25, 2017

Copy link
Copy Markdown
Member

As a temporary workaround could I install an updated pytest via pip?

That should work.

I'll try to take a look at the underlying issue tonight...

@larrybradley

Copy link
Copy Markdown
Member

I installed pytest >= 3.1 via pip as a workaround. Thanks, @bsipocz!

@larrybradley
larrybradley merged commit 88d8e5d into astropy:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants