Repository navigation
Add more plugins and refactor infrastructure - #29
Conversation
…e, pytest-mpl and pytest-cov as dependencies, and updated README.
|
🚀 |
Zac-HD
left a comment
Zac-HD
left a comment
There was a problem hiding this comment.
🎉
Along with the comments below:
- is
pytest-astropyreally still in alpha? What's left to implement? - could add the
Programming Language :: Python :: 3 :: Onlyclassifier - probably a good idea to have a minimum version of
pytest-cov,
as much for thecondaresolver as for general hygiene.
| # Bump hypothesis to >=5.0 in early Jan 2020 | ||
| hypothesis>=4.53 |
There was a problem hiding this comment.
I think there's a decent argument for >=5.1 for timezone support and generally avoiding possible deprecated behaviour 😄
There was a problem hiding this comment.
Ok, I've bumped this - thanks!
| license = BSD | ||
| description = Meta-package containing dependencies for testing | ||
| long_description = file: README.rst | ||
| keywords = pytest, py.test, remotedata, openfiles, doctestplus |
There was a problem hiding this comment.
Pytest maintainer 🎩: the py.test alias is discouraged.
Hypothesis 🎩: could add hypothesis, property-based testing
… a minimum version for pytest-cov
|
@Zac-HD - thanks for the review! I think I've addressed all your comments :) |
saimn
left a comment
saimn
left a comment
There was a problem hiding this comment.
Small comments otherwise looks good!
| ================== | ||
|
|
||
| - Added ``pytest-mpl``, ``pytest-filter-subpackage`` and ``pytest-cov`` | ||
| as dependencies. [#29] |
There was a problem hiding this comment.
Changelog should be expanded with things like hypothesis and Python 2.7 and 3.5 support.
| @@ -0,0 +1,44 @@ | |||
| [metadata] | |||
| name = pytest-astropy | |||
| url = https://astropy.org | |||
There was a problem hiding this comment.
Not sure what's used for other astropy packages, but I find useful to have a more precise URL here, like the github url. Otherwise it is sometimes annoying to find the repository.
There was a problem hiding this comment.
We can add named links with the project_urls option - e.g. this renders like so.
There was a problem hiding this comment.
That's very cool! For now I'll just link to the repo since for this specific package there aren't e.g. separate docs and so on, but I'll definitely be using this for other packages.
There was a problem hiding this comment.
Oooo that is very convenient indeed, @Zac-HD , thanks! @astrofrog , any plans to use project_urls in your APE 17 PR over at astropy?
| from setuptools import setup | ||
|
|
||
| # Setuptools 30.3.0 or later is needed for setup.cfg options to be used | ||
| if LooseVersion(setuptools.__version__) < LooseVersion('30.3.0'): |
There was a problem hiding this comment.
Why not put this in pyproject.toml?
There was a problem hiding this comment.
This is in case people call setup.py directly
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
Just a minor question, otherwise LGTM. Thanks!
5 participants
This PR: