Skip to content

Use generated version for __version__, remove old py2 compat code - #149

Merged
pllim merged 2 commits into
mainfrom
misc
Apr 20, 2022
Merged

pllim merged 2 commits into
mainfrom
misc

Conversation

@saimn

@saimn saimn commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@saimn
saimn requested a review from pllim April 20, 2022 17:44
@saimn saimn added this to the 0.15.0 milestone Apr 20, 2022
@pllim

pllim commented Apr 20, 2022

Copy link
Copy Markdown
Member

Gonna kick off wheel job too, just in case. Thanks!

@pllim pllim closed this Apr 20, 2022
@pllim pllim reopened this Apr 20, 2022
@codecov

codecov Bot commented Apr 20, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #149 (e1d71c5) into main (59b8d17) will increase coverage by 0.28%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   89.14%   89.43%   +0.28%     
==========================================
  Files          23       23              
  Lines        1115     1098      -17     
==========================================
- Hits          994      982      -12     
+ Misses        121      116       -5     
Impacted Files Coverage Δ
sphinx_automodapi/tests/helpers.py 100.00% <ø> (ø)
sphinx_automodapi/utils.py 90.82% <ø> (+2.22%) ⬆️
sphinx_automodapi/automodapi.py 93.75% <66.66%> (+0.45%) ⬆️
...hinx_automodapi/tests/test_autodoc_enhancements.py 95.00% <75.00%> (ø)
sphinx_automodapi/__init__.py 100.00% <100.00%> (ø)
sphinx_automodapi/automodsumm.py 85.62% <100.00%> (-0.05%) ⬇️
sphinx_automodapi/tests/test_automodapi.py 100.00% <100.00%> (+0.83%) ⬆️
sphinx_automodapi/tests/test_cases.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice clean-up!

@pllim
pllim merged commit b602fdc into main Apr 20, 2022
@pllim
pllim deleted the misc branch April 20, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants