Skip to content

Add automodsumm_included_members option, take2 - #165

Merged
pllim merged 1 commit into
astropy:mainfrom
bsipocz:unhide-class-methods
Jan 29, 2024
Merged

pllim merged 1 commit into
astropy:mainfrom
bsipocz:unhide-class-methods

Conversation

@bsipocz

@bsipocz bsipocz commented Apr 19, 2023 •

Copy link
Copy Markdown
Member

This is the rebased version of #103 (as that one was opened from an org fork, maintainers cannot directly push to it)

EDIT: close #121

@bsipocz bsipocz added this to the 0.16.0 milestone Apr 19, 2023
@bsipocz
bsipocz force-pushed the unhide-class-methods branch 2 times, most recently from d701642 to 1e98e30 Compare April 20, 2023 01:05
@codecov

codecov Bot commented Apr 20, 2023 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57e934e) 90.24% compared to head (033e007) 90.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          28       28           
  Lines        1179     1179           
=======================================
  Hits         1064     1064           
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@og113

og113 commented Jul 18, 2023

Copy link
Copy Markdown

Hi all, really appreciate the library you've made. This feature would be really useful to us, and it looks pretty much ready. Could someone possibly take a look and see if it can be merged please? Thank you :)

included in the documentation. This is most commonly used to add special class
methods like ``__getitem__`` and ``__setitem__``. Defaults to
``['__init__', '__call__']``.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit confusing to document this option in the automodapi module. Some options are documented in both modules, some other are not ...

@pllim pllim modified the milestones: 0.16.0, 0.17.0 Aug 17, 2023
@pllim

pllim commented Aug 17, 2023

Copy link
Copy Markdown
Member

This didn't make it to 0.16.0 . Looks like there is an unresolved comment?

@bsipocz

bsipocz commented Aug 17, 2023

Copy link
Copy Markdown
Member Author

and unresolved from the previous PR to add a test. pushes to the PR are welcome :)

@astrofrog
astrofrog removed their request for review October 24, 2023 09:51
@bsipocz
bsipocz force-pushed the unhide-class-methods branch from 1e98e30 to 033e007 Compare January 27, 2024 04:05
@bsipocz

bsipocz commented Jan 27, 2024

Copy link
Copy Markdown
Member Author

Rebased and I would not simmer this along much more, what about rolling a YOLO on it @pllim?

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Let's try it out.

@pllim
pllim merged commit 04947b6 into astropy:main Jan 29, 2024
@pllim

pllim commented Jan 29, 2024

Copy link
Copy Markdown
Member

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants