Repository navigation
Refactor Prometheus usage to explicitly pass a registry #2829
Description
We're currently implicitly using the default registry, which means that tests sometimes flake because two different tests attempt to add the same metric to the same registry, and there's functionality where you can explicitly set up and pass a registry: https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#hdr-Advanced_Uses_of_the_Registry
If we moved to that approach, we could have each test provide its own registry and avoid duplicate registration.
Activity
tstirrat15 commentedon Jan 28, 2026
This may mean we can't use
promauto. Hopefully that isn't too big an issue.miparnisari commentedon Feb 13, 2026
Slightly related: a side effect of registering metrics inside
func init()is that if you run SpiceDB against Spanner (for example, viadocker-compose -f docker-compose.spanner.yaml up --build), you can still see CRDB metrics in http://localhost:9090/metrics. (With zero value, but still...)