Repository navigation
version pinning sqlalchemy to 1.x to fix CI - #381
Merged
Merged
Conversation
srprash
force-pushed
the
pin_sqlalchemy
branch
3 times, most recently
from
March 14, 2023 21:47
79007d9 to
dd524c2
Compare
Contributor
Author
|
Well, now the py35 and py39 tests are failing for the |
srprash
marked this pull request as ready for review
March 14, 2023 22:02
Contributor
|
Can we remove some older Python versions like 3.5 and 3.6 as they're EOL? Or would that be considered a breaking change? |
Contributor
Author
I think it will be a breaking change. If there are customers still using python 3.5 or 3.6 and have minor version dependency on the SDK, they will break on the next minor version release. |
srprash
changed the title
carolabadeer
approved these changes
Mar 14, 2023
Contributor
Author
Turns out these tests have become flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow up from #376 (comment)
Description of changes:
Pinning the sqlalchemy dependency to < 2.0.0 since there are breaking changes in the new major version, rendering it incompatible with the X-Ray SDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.