Skip to content

Disallow new import prop access - #18063

Merged
JLHwung merged 3 commits into
babel:mainfrom
JLHwung:disallow-new-import-prop-access
Aug 23, 2026
Merged

JLHwung merged 3 commits into
babel:mainfrom
JLHwung:disallow-new-import-prop-access

Conversation

@JLHwung

@JLHwung JLHwung commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Q 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Fixed a parser issue similar to acornjs/acorn#1192, detected by the recent test262 update.

@JLHwung JLHwung added PR: Bug Fix 馃悰 A type of pull request used for our changelog categories pkg: parser 7.x: needs backport labels Jun 12, 2026
@babel-bot

babel-bot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/62029

@pkg-pr-new

pkg-pr-new Bot commented Jun 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

commit: be75cc2

@JLHwung

JLHwung commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@liuxingbaoyu It seems to me that the current CI error https://github.com/babel/babel/actions/runs/27420245182/job/81043597260?pr=18063 comes from a flaky test introduced in #18020, could you reproduce this error on your machine?

@liuxingbaoyu

Copy link
Copy Markdown
Member

Sorry for the late reply!
I tried it 10 times and didn't encounter this issue.

@JLHwung

JLHwung commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the late reply! I tried it 10 times and didn't encounter this issue.

Thank you, if it can not be reproduced maybe it is just a bit flip from cosmic rays.

@JLHwung
JLHwung requested a review from liuxingbaoyu August 21, 2026 19:47
@JLHwung
JLHwung force-pushed the disallow-new-import-prop-access branch from 16d8e1b to be75cc2 Compare August 21, 2026 19:48
@JLHwung
JLHwung merged commit c813803 into babel:main Aug 23, 2026
57 checks passed
@JLHwung
JLHwung deleted the disallow-new-import-prop-access branch August 23, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: parser PR: Bug Fix 馃悰 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants