Repository navigation
Remove dependency on loader-utils and drop webpack 4 support - #942
Merged
Merged
Conversation
JLHwung
reviewed
May 4, 2022
| ); | ||
|
|
||
| test.serial.cb( | ||
| "should output files to standard cache dir if set to true in query", |
Contributor
There was a problem hiding this comment.
This is a test on cache behaviour. Can you adapt the query string to options so we don't have to remove this test?
Contributor
Author
There was a problem hiding this comment.
Whoops, sorry about that! Fixed in b9cc145.
Contributor
Author
|
@JLHwung Do you need anything more from me to move this forward? |
|
Thanks for doing this @nied . Really appreciate on removing this vulnerability !! |
JLHwung
reviewed
Oct 23, 2022
|
|
||
| let loaderOptions = loaderUtils.getOptions(this); | ||
|
|
||
| let loaderOptions = this.getOptions(); |
Contributor
There was a problem hiding this comment.
https://webpack.js.org/api/loaders/#thisgetoptionsschema loadContext#getOptions is available only in webpack 5+, we have to drop webpack 4 support, too.
JLHwung
force-pushed
the
remove-loader-utils
branch
from
October 23, 2022 12:58
b9cc145 to
fa15301
Compare
JLHwung
changed the title
liuxingbaoyu
approved these changes
Oct 24, 2022
liuxingbaoyu
approved these changes
Oct 24, 2022
nicolo-ribaudo
approved these changes
Oct 24, 2022
JLHwung
force-pushed
the
remove-loader-utils
branch
from
October 25, 2022 23:31
54768ac to
79ded92
Compare
ivarconr
referenced
this pull request
in Unleash/unleash
Nov 9, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [babel-loader](https://togithub.com/babel/babel-loader) | [`8.2.5` -> `9.1.0`](https://renovatebot.com/diffs/npm/babel-loader/8.2.5/9.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel-loader</summary> ### [`v9.1.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.1.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.1...v9.1.0) #### New features - Pass external dependencies from Babel to Webpack by [@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://togithub.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v9.0.1...v9.1.0 ### [`v9.0.1`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.1) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.0...v9.0.1) ##### Bug Fixes - remove "node:" builtin prefix by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/970](https://togithub.com/babel/babel-loader/pull/970) **Full Changelog**: babel/babel-loader@v9.0.0...v9.0.1 ### [`v9.0.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v8.3.0...v9.0.0) #### What's Changed - update hash method mechanism so it doesn't fail on a fips enabled machine by [@​darmbrust](https://togithub.com/darmbrust) in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - Require babel ^7.12.0 and Node.js >= 14.15.0 versions by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/956](https://togithub.com/babel/babel-loader/pull/956) - Remove dependency on loader-utils and drop webpack 4 support by [@​nied](https://togithub.com/nied) in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) #### New Contributors - [@​darmbrust](https://togithub.com/darmbrust) made their first contribution in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - [@​nied](https://togithub.com/nied) made their first contribution in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) **Full Changelog**: babel/babel-loader@v8.2.5...v9.0.0 ### [`v8.3.0`](https://togithub.com/babel/babel-loader/releases/tag/v8.3.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v8.2.5...v8.3.0) #### New features - Pass external dependencies from Babel to Webpack by [@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://togithub.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v8.2.5...v8.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xNy4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
kodiakhq Bot
referenced
this pull request
in weareinreach/InReach
Nov 10, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [babel-loader](https://togithub.com/babel/babel-loader) | [`8.3.0` -> `9.1.0`](https://renovatebot.com/diffs/npm/babel-loader/8.3.0/9.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel-loader</summary> ### [`v9.1.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.1.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.1...v9.1.0) #### New features - Pass external dependencies from Babel to Webpack by [@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://togithub.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v9.0.1...v9.1.0 ### [`v9.0.1`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.1) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.0...v9.0.1) #### Bug Fixes - remove "node:" builtin prefix by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/970](https://togithub.com/babel/babel-loader/pull/970) **Full Changelog**: babel/babel-loader@v9.0.0...v9.0.1 ### [`v9.0.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v8.3.0...v9.0.0) #### What's Changed - update hash method mechanism so it doesn't fail on a fips enabled machine by [@​darmbrust](https://togithub.com/darmbrust) in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - Require babel ^7.12.0 and Node.js >= 14.15.0 versions by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/956](https://togithub.com/babel/babel-loader/pull/956) - Remove dependency on loader-utils and drop webpack 4 support by [@​nied](https://togithub.com/nied) in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) #### New Contributors - [@​darmbrust](https://togithub.com/darmbrust) made their first contribution in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - [@​nied](https://togithub.com/nied) made their first contribution in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) **Full Changelog**: babel/babel-loader@v8.2.5...v9.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach). PR-URL: #41 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
JoeKarow
referenced
this pull request
in weareinreach/InReach
Dec 3, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [babel-loader](https://togithub.com/babel/babel-loader) | [`8.3.0` -> `9.1.0`](https://renovatebot.com/diffs/npm/babel-loader/8.3.0/9.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel-loader</summary> ### [`v9.1.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.1.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.1...v9.1.0) #### New features - Pass external dependencies from Babel to Webpack by [@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://togithub.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v9.0.1...v9.1.0 ### [`v9.0.1`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.1) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.0...v9.0.1) #### Bug Fixes - remove "node:" builtin prefix by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/970](https://togithub.com/babel/babel-loader/pull/970) **Full Changelog**: babel/babel-loader@v9.0.0...v9.0.1 ### [`v9.0.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v8.3.0...v9.0.0) #### What's Changed - update hash method mechanism so it doesn't fail on a fips enabled machine by [@​darmbrust](https://togithub.com/darmbrust) in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - Require babel ^7.12.0 and Node.js >= 14.15.0 versions by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/956](https://togithub.com/babel/babel-loader/pull/956) - Remove dependency on loader-utils and drop webpack 4 support by [@​nied](https://togithub.com/nied) in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) #### New Contributors - [@​darmbrust](https://togithub.com/darmbrust) made their first contribution in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - [@​nied](https://togithub.com/nied) made their first contribution in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) **Full Changelog**: babel/babel-loader@v8.2.5...v9.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach). PR-URL: #41 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
1 task
benelan
referenced
this pull request
in Esri/calcite-design-system
Dec 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [babel-loader](https://togithub.com/babel/babel-loader) | [`8.3.0` -> `9.1.3`](https://renovatebot.com/diffs/npm/babel-loader/8.3.0/9.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel-loader (babel-loader)</summary> ### [`v9.1.3`](https://togithub.com/babel/babel-loader/releases/tag/v9.1.3) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.1.2...v9.1.3) #### Security dependency updates - Bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/babel/babel-loader/pull/982](https://togithub.com/babel/babel-loader/pull/982) - Bump semver from 7.3.2 to 7.5.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/babel/babel-loader/pull/993](https://togithub.com/babel/babel-loader/pull/993) - bump find-cache-dir to v4 by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/995](https://togithub.com/babel/babel-loader/pull/995) #### New Contributors - [@​piwysocki](https://togithub.com/piwysocki) made their first contribution in [https://github.com/babel/babel-loader/pull/981](https://togithub.com/babel/babel-loader/pull/981) - [@​comoser](https://togithub.com/comoser) made their first contribution in [https://github.com/babel/babel-loader/pull/897](https://togithub.com/babel/babel-loader/pull/897) **Full Changelog**: babel/babel-loader@v9.1.2...v9.1.3 ### [`v9.1.2`](https://togithub.com/babel/babel-loader/releases/tag/v9.1.2) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.1.1...v9.1.2) 9.1.1 was a broken release, it didn't include all the commits. #### Dependencies updates - Bump qs from 6.5.2 to 6.5.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/babel/babel-loader/pull/977](https://togithub.com/babel/babel-loader/pull/977) - Bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/babel/babel-loader/pull/980](https://togithub.com/babel/babel-loader/pull/980) #### Misc - GitHub Workflows security hardening by [@​sashashura](https://togithub.com/sashashura) in [https://github.com/babel/babel-loader/pull/976](https://togithub.com/babel/babel-loader/pull/976) #### New Contributors - [@​sashashura](https://togithub.com/sashashura) made their first contribution in [https://github.com/babel/babel-loader/pull/976](https://togithub.com/babel/babel-loader/pull/976) **Full Changelog**: babel/babel-loader@v9.1.0...v9.1.2 ### [`v9.1.1`](https://togithub.com/babel/babel-loader/compare/v9.1.0...v9.1.1) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.1.0...v9.1.1) ### [`v9.1.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.1.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.1...v9.1.0) #### New features - Pass external dependencies from Babel to Webpack by [@​nicolo-ribaudo](https://togithub.com/nicolo-ribaudo) in [https://github.com/babel/babel-loader/pull/971](https://togithub.com/babel/babel-loader/pull/971) **Full Changelog**: babel/babel-loader@v9.0.1...v9.1.0 ### [`v9.0.1`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.1) [Compare Source](https://togithub.com/babel/babel-loader/compare/v9.0.0...v9.0.1) #### Bug Fixes - remove "node:" builtin prefix by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/970](https://togithub.com/babel/babel-loader/pull/970) **Full Changelog**: babel/babel-loader@v9.0.0...v9.0.1 ### [`v9.0.0`](https://togithub.com/babel/babel-loader/releases/tag/v9.0.0) [Compare Source](https://togithub.com/babel/babel-loader/compare/v8.3.0...v9.0.0) #### What's Changed - update hash method mechanism so it doesn't fail on a fips enabled machine by [@​darmbrust](https://togithub.com/darmbrust) in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - Require babel ^7.12.0 and Node.js >= 14.15.0 versions by [@​JLHwung](https://togithub.com/JLHwung) in [https://github.com/babel/babel-loader/pull/956](https://togithub.com/babel/babel-loader/pull/956) - Remove dependency on loader-utils and drop webpack 4 support by [@​nied](https://togithub.com/nied) in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) #### New Contributors - [@​darmbrust](https://togithub.com/darmbrust) made their first contribution in [https://github.com/babel/babel-loader/pull/939](https://togithub.com/babel/babel-loader/pull/939) - [@​nied](https://togithub.com/nied) made their first contribution in [https://github.com/babel/babel-loader/pull/942](https://togithub.com/babel/babel-loader/pull/942) **Full Changelog**: babel/babel-loader@v8.2.5...v9.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Feb 26, 2024
%5D(https%3A%2F%2Frenovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior?
Currently,
babel-loaderdepends onloader-utilswhich in turn depends on[email protected]which in turn depends on[email protected]. Minimist of this version is vulnerable to GHSA-xvch-5gv4-984h. I started working on updatingloader-utilsto a new version, but as far as I can tell it's not really needed, asgetOptionswas removed in 3.0.0 and we can safely useloaderContext.getOptionsinstead.What is the new behavior?
The only change in behaviour I'm aware of is that passing options as query parameters is no longer possible. This is explained in further detail at https://github.com/webpack/loader-utils/releases/tag/v3.0.0 - but since the usage of query parameters seems to be frowned upon I figured it was an ok trade-off.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Impact: Options can no longer be passed as query string parameters
Migration path for existing applications: move to use the
options-object in the configuration instead. Examples of this migration can be found in the changes I made in the tests.Github Issue(s) this is regarding:
Impact: Dropped webpack 4 support
Migration path for existing applications: Upgrade webpack to 5 or keep using babel-loader@8.
Other information:
This is my first contribution to
babel-loaderand fair warning: I don't 100% know what I'm doing in this code base so I'm happy to make any changes if that's needed.Fixes #954