Skip to content
This repository was archived by the owner on Aug 13, 2026. It is now read-only.
This repository was archived by the owner on Aug 13, 2026. It is now read-only.

Difficult to mock when unit testing [JIRA: CLIENTS-520] #526

Description

@jplock

Right now, none of the API classes implement equals, hashCode or toString() which makes mocking and comparing them to mocked copies difficult. Would you accept a pull request to implement these methods in at least RiakCommand but others may be required?

Activity

  1. changed the title [-]Difficult to mock when unit testing[/-] [+]Difficult to mock when unit testing [JIRA: CLIENTS-520][/+] on Jul 17, 2015
  2. alexmoore commented on Jul 17, 2015

    @alexmoore
    Contributor

    Sure! PRs with good ideas are always welcome.

  3. jplock commented on Jul 17, 2015

    @jplock
    ContributorAuthor

    sure thing, I'll submit one

  4. alexmoore commented on Jul 24, 2015

    @alexmoore
    Contributor

    This was merged into the develop branch, and should be out with the next release (today or next week).

  5. added this to the Java Client v2.0.2 milestone on Jul 24, 2015
  6. stela commented on Oct 22, 2015

    @stela
    Contributor

    See also #557, which in the same spirit adds equals(), hashCode() and toString() methods to RiakObject and dependent classes. This is useful when mocking out RiakClient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions