This repository was archived by the owner on Aug 13, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 13, 2026. It is now read-only.
Superfluous declarations of UnknownHostException [JIRA: CLIENTS-614] #552
Description
Activity
- changed the title
[-]Superfluous declarations of UnknownHostException[/-][+]Superfluous declarations of UnknownHostException [JIRA: CLIENTS-614][/+]on Sep 27, 2015 Yeah, that looks like a vestigial piece of code that was originally in the RiakNode constructor and branched it's way out. We only need UnknownHostException on RiakNode's
start&buildNodesfunctions, and RiakCluster'saddNodeI think. I'll cut those declared ones out of the constructors this week sometime for the next release, unless you'd like to submit a PR for them :)Thanks!
Also I think the idea was originally we'd check to see if the host was viable when we first created the node, but we just left that up to
startfor api design reasons.Added pull request to fix this.
The constructors of RiakCluster and RiakNode and the corresponding Builders' build()-methods declare the UnknownHostException. But I don't see a way how this exception can occur. May it be that these declarations are superfluous? This might relate to #519.