Repository navigation
2i Queries with Coverage Context Aren't Built Correctly [JIRA: CLIENTS-961] #658
Description
Activity
- changed the title
[-]2i Queries with Coverage Context Aren't Built Correctly[/-][+]2i Queries with Coverage Context Aren't Built Correctly [JIRA: CLIENTS-961][/+]on Aug 11, 2016 Don't need this just yet, but will in the future.
@alexmoore The idea was to do not overcomplicate Query Builders by introducing a specific constructor for for each possible case, therefore by using as an example BinQuery:
here is constructors available for Builder in BinIndexQuery:
creation with Range:
https://github.com/basho/riak-java-client/blob/develop/src/main/java/com/basho/riak/client/api/commands/indexes/BinIndexQuery.java#L188creation with exact match:
https://github.com/basho/riak-java-client/blob/develop/src/main/java/com/basho/riak/client/api/commands/indexes/BinIndexQuery.java#L204creation with coverage context:
https://github.com/basho/riak-java-client/blob/develop/src/main/java/com/basho/riak/client/api/commands/indexes/BinIndexQuery.java#L171Usage of CoverageContext in conjunction with range or match requires to constructor a builder by using specific constructor for
range or exact match and then to provide coverage context by using this method:
https://github.com/basho/riak-java-client/blob/develop/src/main/java/com/basho/riak/client/api/commands/indexes/SecondaryIndexQuery.java#L523please let me know if I missed something or you have objections/concerns
Nope, looks good. I think I was a little confused at first how to build the match/range + coverage queries, but that straightens it out. Just need to document it then once we start pushing coverage more.
This was fixed for the 2.0.7 release.
_[posted via JIRA by Alexander Moore]_
I started with a test failure:
And realized the 2i Coverage Context queries weren't including either a match or a range, so need to expand the api to cover that.
Reference:
Context with match
Context with Range