Skip to content

ctx.action.run_shell: use_default_shell_env=True overwrites env={...}  #5980

Description

@c-parsons

A user writing a new experimental rule ran into this issue, that it seemed that enviornment variables were not being correctly set on an action created with ctx.action.run_shell, when use_default_shell_env=True. We should probably throw some sort of error when a user tries to specify both env and use_default_shell_env=True, to avoid this confusion in the future.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)team-Rules-APIAPI for writing rules/aspects: providers, runfiles, actions, artifactstype: buguntriagedHas not yet been seen by appropriate subteam

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions