Skip to content

Incorrect tailwind line-height classes generated  #125

Open

Description

@liampcollins

Hi,

It looks like there is an issue with the outputted tailwind line-height classes. We have a text layer in Figma with font-size 14px and line-height 24px. The outputted tailwind classes are text-sm which is correct, and leading-normal which is (1.5 x font-size) so gives us 21px which is incorrect.

Screenshot 2024-10-21 at 16 33 35 Screenshot 2024-10-21 at 16 35 04

Activity

  1. liampcollins commented on Oct 21, 2024

    @liampcollins
    Author

    I believe the tailwind named classes (like leading-normal) are relative to the font size rather than being rems so I think the font size may need to be passed through to here perhaps?

    image
  2. bernaferrari commented on Oct 21, 2024

    @bernaferrari
    Owner

    AFAIK text-sm overrides leading (but maybe it is order dependent) but maybe I'm wrong. If you can find the exact issue I surely can fix :)

  3. liampcollins commented on Oct 22, 2024

    @liampcollins
    Author

    Thanks for the response. Perhaps the order can make a difference but in the example I have it is using the leading class. I think the bug originates from an assumption in the code that leading-normal represents 1.5rem when in fact it is 1.5 x font-size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions