Repository navigation
Warning log - #144
Warning log#144
Conversation
|
I also removed some of the extra UI when there were no layers selected. 
|
| <div className="flex flex-col bg-red-700 text-white p-4 w-full"> | ||
| <h3 className="text-lg">Warnings:</h3> | ||
| <ul className="list-disc list-inside"> |
There was a problem hiding this comment.
needs to support both light and dark mode, I would do something like bg-red-300 text-black dark:bg-red-700 dark:text-white, or use opacity like dark:bg-red-700/40
There was a problem hiding this comment.
I would probably also use a lucide warning icon and maybe yellow color since it is not THAT bad, just a warning, not an error
|
I like it, thanks |
|
I've added the icon and changed the color to yellow. The dark one is slightly darker but changing it too much didn't look correct to me. 
|
|
Oh no, now this has conflicts. Do prefer me to revert the other one, merge this, then merge the other one or do you want to rebase this? Whatever is easier for you. I forgot to merge this, sorry. |
|
This should be rebased and all fixed. |
|
Thanks!! |
2 participants
I've added a global object in backend/common that allows you to track errors when doing the conversion from Figma nodes to code.
The file exposes
warnings(aSet<string>),addWarning(), andclearWarnings()The warnings are passed on to the UI to display to the user.
The warnings are also logged to console using
console.warn()Known issue: Any warnings for HTML always appear because they are triggered by the HTML Preview.
Known issue: I added warnings for a few conversion issues I was aware of but I assume there are many more that are not annotated.