Repository navigation
flutter: skip gen Container with empty props - #192
Merged
bernaferrari merged 1 commit intoMar 18, 2025
Merged
Conversation
Owner
|
Thanks!! |
canewsin
force-pushed
the
skip-empty-container
branch
from
March 13, 2025 09:48
426d71b to
8bf7096
Compare
Owner
|
It is probably better to do like props =..., then isEmptyProps() else... |
Contributor
Author
|
Extract props to a separate variable? Gotcha |
canewsin
force-pushed
the
skip-empty-container
branch
from
March 15, 2025 04:59
8bf7096 to
4bfcb85
Compare
Contributor
Author
|
@bernaferrari done |
Owner
|
Is empty props working as it should? Because the width/height already check for zero and ignore that. Not sure the difference |
Contributor
Author
|
yup, this function checks all properties and skips if property is default which resulted in unnecessary container. const hasEmptyProps = (props: Record<string, string>): boolean => {
...
}currently these props are being checked for default values properties.width = skipDefaultProperty(width, "0");
properties.height = skipDefaultProperty(height, "0");
properties.padding = propPadding;
properties.clipBehavior = clipBehavior;
const parsedDecoration = skipDefaultProperty(
propBoxDecoration,
"BoxDecoration()",
);
properties.decoration = clipBehavior ? propBoxDecoration : parsedDecoration;
const isEmptyProps = hasEmptyProps(properties);without this check result will be Before Patch Container(
child: Column(
children: [SomeWidgetsHere()...]
)
)After Patch Column(
children: [SomeWidgetsHere()...]
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.