Repository navigation
feat: use serial mode to reduce execution time - #15
Merged
Merged
Conversation
Member
|
Wow, biome got even faster 🤯 |
ematipico
changed the title
ematipico
approved these changes
Dec 6, 2024
Contributor
Author
|
Or, at least, pre-commit isn't making it slower :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, pre-commit spawns parallel processes for checking files. Biome is already fast, so parallelization adds little benefit but makes output harder to read by splitting summary statistics across processes.
This change ensures Biome runs serially to provide cleaner, combined output. Local benchmarks show Biome still completes quickly (~0.2s) without parallelization.
Before:
After:
Note that the runtime actually drops, at least on my machine for this project. The cost of spawning lots of separate processes seems to be higher than actually linting the files.