Repository navigation
Set explicit headers before defaults and refine logging - #7249
Merged
chrisrueger merged 1 commit intoMay 27, 2026
Merged
Conversation
chrisrueger
marked this pull request as ready for review
May 26, 2026 17:57
bjhargrave
reviewed
May 26, 2026
Contains some suggested improvements of previous PR which I merged too fast. - Call setHeaders(...) before setHeadersIfAbsent(...) so header defaults are only applied when a header is not already present. - Improve logging of default headers (only log if set) Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
7228-finetuning-httpclient-changes
branch
from
May 27, 2026 05:11
71fc85b to
d7f3509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains some suggested improvements of previous PR which I merged too fast.