Repository navigation
[fix] #750: misspelled config macros - #755
Merged
Merged
Conversation
vissarion
approved these changes
Sep 24, 2020
vissarion
left a comment
vissarion
left a comment
Member
There was a problem hiding this comment.
Seems OK to me, the macro BOOST_NO_INT64_Tindicates the absence of int64_t and uint64_t (as documented in https://www.boost.org/doc/libs/1_74_0/libs/config/doc/html/boost_config/cstdint.html) and the other two (BOOST_NO_INT64, BOOST_HAS_INT64_T) are not in boost anymore.
Contributor
Author
|
@vissarion can you merge this? |
Member
It's a good practice to have at least 2 reviews for each merged PR. @awulkiew @barendgehrels @mloskot any feedback on this PR? |
Member
|
Yes, I'm ok with merging it. Thanks @ayaankhan98. Note that all of such checks could be removed because we're moving to the newer standard and 64b int is guaranteed to be available. But let's not do that for now and leave it as it is. |
awulkiew
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refer to #750