Wrapped multi-errors should implement Unwrap() []error #38

Activity

1. abhinav commented on Nov 28, 2023

   

   abhinav

   on Nov 28, 2023

   Last edited by abhinav

   ContributorAuthor

   More actions

   This hides the actual list of errors for wrapped multi-errors.

   Actually, this isn't quite right. Even with just Unwrap() error, we're exposing the underlying list on the "next" layer, so it's not entirely inaccessible. But it's still going to be annoying. Although I'm not entirely certain that implementing Unwrap() []error is the right choice there, because transparently skipping the actual wrapped error means fmt.Errorf("information: %w %w", a, b) will unpack to a and b, ignoring information entirely.

   Separately, maybe we also need an errtrace.Unwrap that's a drop-in replacement for errors.Unwrap, and all it does is transparently unwrap the top-level errtrace error—if any. That can be a separate discussion.

   👍React with 👍1Reacted by Roberto Montagna
2. abhinav

   changed the title [-]Wrapped multi-errors should implement Unwrap() []error[/-] [+]Add errtrace.Unwrap() function as drop-in for errors.Unwrap[/+] on Nov 29, 2023
3. abhinav

   changed the title [-]Add errtrace.Unwrap() function as drop-in for errors.Unwrap[/-] [+]Wrapped multi-errors should implement Unwrap() []error[/+] on Nov 29, 2023