Repository navigation
cmd/errtrace: Built-in list of exclusions #60
Description
Activity
- changed the title
[-]Built-in list of exclusions[/-][+]cmd/errtrace: Built-in list of exclusions[/+]on Nov 29, 2023 I just ran into this and wondered why IO code stopped functioning with my Readers, after running the CLI instrumentation tool. This would be very helpful, even if it's not perfect
Reacted by Abhinav Gupta and ClaireExcluding explicit
io.EOFwould be a big improvement, but I assume wrapped readers could still break? Could we handle this case if type info was available?func (b *gzippedBlob) Read(p []byte) (int, error) { return b.gz.Read(p) }
Wrapped readers make it pretty tricky since there isn't necessarily any reference to
ioorio.EOFin those cases.While we were initially thinking of exclusions at compile-time, I wonder if we should also consider runtime exclusions. The compile-time code can instrument all calls, but the
Wrapmethod could check against a runtime list and return the original error in those cases.Reacted by Abhinav Gupta
From:
Originally posted by @prashantv in #57 (comment)
We should consider a built-in list of ignores.
These will be pretty simplistic since we don't use type information (yet).
We already have an exclusion for
Unwrap() errormethods.This issue is to track both, the feature and what should be in the exclusions initially:
io.EOFreturned from aRead() (int, error)method