Repository navigation
Revert "Add BaRISTA model" - #1172
Merged
Merged
Conversation
This reverts commit 16ee1d4.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The BaRISTA reversion and associated cleanup are complete with no unresolved review issues.
Review effort: Lite
Findings: None
What changed in this PR
Reverts the BaRISTA model and its supporting code, APIs, documentation, tests, metadata, and licensing references.
Changes:
- Removes the BaRISTA implementation and exports.
- Removes related GLU and rotary helpers.
- Cleans up tests, documentation, metadata, and license notices.
| File | Description |
|---|---|
test/unit_tests/models/test_return_features.py |
Removes BaRISTA test coverage. |
NOTICE.txt |
Removes BaRISTA licensing notice. |
docs/whats_new.rst |
Removes the BaRISTA release entry. |
docs/api.rst |
Removes BaRISTA API listings. |
braindecode/modules/blocks.py |
Removes the BaRISTA-specific GLU block. |
braindecode/modules/__init__.py |
Removes the GLU export. |
braindecode/models/util.py |
Removes BaRISTA model configuration. |
braindecode/models/summary.csv |
Removes BaRISTA metadata. |
braindecode/models/barista.py |
Removes the BaRISTA implementation. |
braindecode/models/__init__.py |
Removes the BaRISTA export. |
braindecode/functional/functions.py |
Removes rotary helper functions. |
braindecode/functional/__init__.py |
Removes rotary helper exports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 142 142
Lines 16303 16303
=======================================
Hits 14114 14114
Misses 2189 2189 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1171