Repository navigation
Link BrainOmni's MIT licence in NOTICE.txt - #1229
Merged
bruAristimunha merged 2 commits intoOct 5, 2026
Merged
Conversation
BrainOmni is ported from OpenTSLab/BrainOmni (MIT); its SEANet codec from Meta's EnCodec (MIT) and its residual VQ from lucidrains/vector-quantize-pytorch (MIT). Per the model-port convention a port links to its licence rather than bundling the text, so add only the file lines for brainomni.py and the shared modules/quantization.py under the existing MIT section (the MIT link is already present) and leave pyproject.toml/MANIFEST.in untouched.
Resolved NOTICE.txt by keeping both MIT entries.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The notice accurately follows the repository’s non-BSD licensing convention.
Review effort: Balanced
Findings: None
What changed in this PR
Records the MIT provenance for the upcoming BrainOmni port.
Changes:
- Lists BrainOmni and quantization modules as MIT-licensed.
- Documents their upstream derivations.
| File | Description |
|---|---|
NOTICE.txt |
Adds BrainOmni components and MIT provenance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1229 +/- ##
=======================================
Coverage 87.98% 87.98%
=======================================
Files 151 151
Lines 17615 17615
=======================================
Hits 15499 15499
Misses 2116 2116 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Licence groundwork for the BrainOmni port (split 1/3 of #1043). BrainOmni is ported from OpenTSLab/BrainOmni (MIT); its SEANet codec from Meta's EnCodec (MIT) and its residual VQ from lucidrains/vector-quantize-pytorch (MIT). Following the model-port convention a port links to its licence rather than bundling the text, so this only adds
braindecode/models/brainomni.pyandbraindecode/modules/quantization.pyunder the existing "MIT Licensed Files" section ofNOTICE.txtand leavespyproject.toml/MANIFEST.inuntouched. No code.Licence: MIT.