Skip to content

CI: make the Codecov upload non-blocking - #1234

Merged
bruAristimunha merged 1 commit into
braindecode:masterfrom
bruAristimunha:ci/codecov-non-blocking
Oct 5, 2026
Merged

bruAristimunha merged 1 commit into
braindecode:masterfrom
bruAristimunha:ci/codecov-non-blocking

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

The Codecov upload step has failed with an SSL handshake error to codecov.io on every test (ubuntu-latest, 3.12) run today while the test step itself passes, forcing reruns or admin merges. fail_ci_if_error: false + continue-on-error: true on that single step; nothing else in the workflow changes. Authorized by @bruAristimunha.

The upload to codecov.io has been failing with an SSL handshake error on every run while the test step passes; the step now reports but no longer fails the job.
Copilot AI balanced review requested due to automatic review settings October 5, 2026 15:45
@bruAristimunha bruAristimunha added no changelog maintenance Bug fix / refactor / tests — not a new model labels Oct 5, 2026
@bruAristimunha
bruAristimunha merged commit 0f681db into braindecode:master Oct 5, 2026
11 of 15 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Makes the Codecov upload step non-blocking so transient Codecov/SSL issues don’t fail otherwise-successful CI runs.

Changes:

  • Marks the Codecov upload step as continue-on-error: true
  • Sets fail_ci_if_error: false for the Codecov action
File Description
.github/​workflows/​tests.yml Makes the Codecov upload step non-fatal to prevent flaky CI failures unrelated to test results

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

if: ${{ matrix.run-coverage }}
with:
fail_ci_if_error: true
fail_ci_if_error: false
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.99%. Comparing base (5e00a5b) to head (433922e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1234   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files         151      151           
  Lines       17628    17628           
=======================================
  Hits        15511    15511           
  Misses       2117     2117           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Bug fix / refactor / tests — not a new model no changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants