Skip to content

DeprecationWarning on node 7 #76

Closed

Description

@dominicbarnes

I'm using browser-pack in a project of my own, and I discovered a warning when running my tests on node 7. (recently released)

(node:28861) DeprecationWarning: Using Buffer without new will soon stop working. Use new Buffer(), or preferably Buffer.from(), Buffer.allocUnsafe() or Buffer.alloc() instead.

There are several places in this library that use the Buffer() syntax instead of new Buffer(), and it should be an easy update, as well as being backwards-compatible.

Activity

  1. dominicbarnes commented on Oct 26, 2016

    @dominicbarnes
    ContributorAuthor

    Looks like there is already a PR (#75) to address this, can we get it merged?

  2. TehShrike commented on Oct 26, 2016

    @TehShrike

    I'm getting this deprecation warning as well.

  3. ai commented on Nov 21, 2016

    @ai

    Seems like issue was fixed c91b816

    But this fix was not released.

    @zertosh @thealphanerd @substack how I can help with release of this fix?

  4. ai commented on Nov 21, 2016

    @ai

    Every Browserify user with node.js 7 have this warning browserify/browserify#1616 (comment)

  5. davidmarkclements commented on Feb 10, 2017

    @davidmarkclements

    Afaik the deprecation is being (or has been) reversed (davidmarkclements/0x#52)

  6. ghost closed this as completedon Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions