Skip to content

Fix support for node v0.8 support - #1939

Merged
ljharb merged 3 commits into
browserify:masterfrom
kumavis:fix-v0.8
Dec 28, 2019
Merged

ljharb merged 3 commits into
browserify:masterfrom
kumavis:fix-v0.8

Conversation

@kumavis

@kumavis kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor

Comment thread package.json Outdated
Comment thread package.json Outdated
kumavis and others added 2 commits December 28, 2019 11:44
Co-Authored-By: Jordan Harband <[email protected]>
Co-Authored-By: Jordan Harband <[email protected]>
@ljharb ljharb added the bug label Dec 28, 2019
@kumavis

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

I also noticed appveyor and travis tests dont have the same engine coverage...

@kumavis

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

would be nice to document supported platforms for both browserify and bundles

@kumavis

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

also if we could turn on greenkeeper for only in-range dep updates? would give us an idea if our deps break

@kumavis

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

woof appveyor takes forever

@kumavis

kumavis commented Dec 28, 2019

Copy link
Copy Markdown
Contributor Author

@ljharb finished cooking

@ljharb

ljharb commented Dec 28, 2019

Copy link
Copy Markdown
Member

We should definitely make sure “engines” is set correctly, as are CI matrices.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json###

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants