Conversation
This was referenced Sep 10, 2023
legobeat
marked this pull request as ready for review
September 10, 2023 00:23
legobeat
force-pushed
the
deps-readable-stream-3
branch
from
September 10, 2023 01:43
06004fb to
2116d2b
Compare
ljharb
requested changes
Sep 10, 2023
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
An upgrade that forces us to drop support of a node version is an upgrade not worth doing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revival of a past attempt (#1938) which was partially applied in #1970 .
This follows up to also update the direct dependency on
readable-streamto v3.Resolves